linux-kernel - Re: [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131214203425.GJ17601@leaf>
Date:	Sat, 14 Dec 2013 12:34:25 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Matt Porter <mporter@...nel.crashing.org>,
	Alexandre Bounine <alexandre.bounine@....com>
Subject: Re: [PATCH 3/3] drivers: rapidio: Remove unused function
 rio_remove_sysfs_dev_files() in rio-sysfs.c

On Sat, Dec 14, 2013 at 06:23:10PM +0530, Rashika Kheria wrote:
> This patch removes the function rio_remove_sysfs_dev_files() in
> rio-sysfs.c because it is unused.
> 
> Thus, it also eliminates the following warning in rio-sysfs.c:
> drivers/rapidio/rio-sysfs.c:295:6: warning: no previous prototype for ‘rio_remove_sysfs_dev_files’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/rapidio/rio-sysfs.c |   16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/rapidio/rio-sysfs.c b/drivers/rapidio/rio-sysfs.c
> index e0221c6..8929b9e 100644
> --- a/drivers/rapidio/rio-sysfs.c
> +++ b/drivers/rapidio/rio-sysfs.c
> @@ -286,22 +286,6 @@ int rio_create_sysfs_dev_files(struct rio_dev *rdev)
>  	return err;
>  }
>  
> -/**
> - * rio_remove_sysfs_dev_files - cleanup RIO specific sysfs files
> - * @rdev: device whose entries we should free
> - *
> - * Cleanup when @rdev is removed from sysfs.
> - */
> -void rio_remove_sysfs_dev_files(struct rio_dev *rdev)
> -{
> -	device_remove_bin_file(&rdev->dev, &rio_config_attr);
> -	if (rdev->pef & RIO_PEF_SWITCH) {
> -		device_remove_file(&rdev->dev, &dev_attr_routes);
> -		device_remove_file(&rdev->dev, &dev_attr_lnext);
> -		device_remove_file(&rdev->dev, &dev_attr_hopcount);
> -	}
> -}
> -
>  static ssize_t bus_scan_store(struct bus_type *bus, const char *buf,
>  				size_t count)
>  {
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/