linux-kernel - RE: [PATCH] drivers: hv: Mark the function hv_synic_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Dec 2013 22:11:20 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Josh Triplett <josh@...htriplett.org>,
	Rashika Kheria <rashika.kheria@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Haiyang Zhang" <haiyangz@...rosoft.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
Subject: RE: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as
 static in hv.c



> -----Original Message-----
> From: Josh Triplett [mailto:josh@...htriplett.org]
> Sent: Saturday, December 14, 2013 12:57 PM
> To: Rashika Kheria
> Cc: linux-kernel@...r.kernel.org; KY Srinivasan; Haiyang Zhang;
> devel@...uxdriverproject.org
> Subject: Re: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static
> in hv.c
> 
> On Sat, Dec 14, 2013 at 07:00:06PM +0530, Rashika Kheria wrote:
> > This patch marks the function hv_synic_free_cpu() as static in hv.c
> > because it is not used outside this file.
> >
> > Thus, it also eliminates the following warning in hv.c:
> > drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’
> [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> 
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
Thank you.

Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> 
> >  drivers/hv/hv.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > index f0c5e07..bcb4950 100644
> > --- a/drivers/hv/hv.c
> > +++ b/drivers/hv/hv.c
> > @@ -301,7 +301,7 @@ err:
> >  	return -ENOMEM;
> >  }
> >
> > -void hv_synic_free_cpu(int cpu)
> > +static void hv_synic_free_cpu(int cpu)
> >  {
> >  	kfree(hv_context.event_dpc[cpu]);
> >  	if (hv_context.synic_event_page[cpu])
> > --
> > 1.7.9.5
> >