linux-kernel - Re: [PATCH v2 2/4] pciehp: Use link change notifications for hot-plug and removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131214033911.GA25115@roeck-us.net>
Date:	Fri, 13 Dec 2013 19:39:11 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Rajat Jain <rajatjain@...iper.net>,
	Rajat Jain <rajatjain.linux@...il.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Yijing Wang <wangyijing@...wei.com>,
	Paul Bolle <pebolle@...cali.nl>,
	Rajat Jain <rajatxjain@...il.com>,
	Guenter Roeck <groeck@...iper.net>
Subject: Re: [PATCH v2 2/4] pciehp: Use link change notifications for
 hot-plug and removal

On Fri, Dec 13, 2013 at 05:58:08PM -0800, Yinghai Lu wrote:
> On Fri, Dec 13, 2013 at 1:14 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> > On Fri, Dec 13, 2013 at 12:04 PM, Rajat Jain <rajatjain@...iper.net> wrote:
> >
> >> Once again: the way I interpret this is:
> >> * Always enable Link events.
> >> * Disable presence events if attention button is present.
> >
> > That sounds like a good plan to me.
> 
> How about Diag_Reset from MPT2SAS and others?
> link could up and down
> 

Good question. Another question is how this would play together
with AER functions, specifically link_reset and slot_reset.

In this context ... is it possible that the link_reset function from struct
pci_error_handlers is never called, or am I missing something ?

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/