linux-kernel - Re: [PATCH] ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHaF_khsrAkaepHX8yObxKQx6aq9oagzRgAx=J6G6R2fCUN7wg@mail.gmail.com>
Date:	Sun, 15 Dec 2013 10:38:04 +0800
From:	Alex Ling <kasimling@...il.com>
To:	Tomasz Figa <tomasz.figa@...il.com>
Cc:	Rob Herring <rob.herring@...xeda.com>,
	Mark Rutland <mark.rutland@....com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	Stephen Warren <swarren@...dotorg.org>,
	ijc+devicetree@...lion.org.uk,
	"kgene.kim@...sung.com" <kgene.kim@...sung.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: add board dts file for EXYNOS4412 based
 TINY4412 board

Tomasz,
Thanks for reviewing. I'll fix the patch description and style problems.


Regards,
Alex

On Sun, Dec 15, 2013 at 2:57 AM, Tomasz Figa <tomasz.figa@...il.com> wrote:
> Hi Alex,
>
> On Friday 15 of November 2013 21:09:29 Alex Ling wrote:
>> Add a minimal board dts file for EXYNOS4412 based FriendlyARM's
>> TINY4412 board. This patch including adds the node to support
>> peripherals like UART, SD card on SDMMC2 port, and this patch
>> adds GPIO connected LEDS and configure its properties like
>> following:
>> LED1: use 'heartbeat' trigger, blinking while the board is running.
>> LED4: use 'mmc0' trigger, on when mmc0 is accessing.
>> LED2 and LED3 can be controlled from userspace.
>
> Well, all the LEDs can be controlled from userspace. The default trigger
> is just the initial setting, which can be changed later by userspace.
> It's just a general comment, not an issue with the patch, though.
>
> Anyway, you don't need such detailed patch description, as you can see
> most of the things directly from the code. In case of this patch, just the
> list of supported peripherals is fine, without going into minor details,
> such as LED triggers.
>
> Also, please see my comments inline.
>
> [snip]
>> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
>> new file mode 100644
>> index 0000000..78ace14
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> [snip]
>> +     leds {
>> +             compatible = "gpio-leds";
>
> style: A blank line should be separating properties from nodes.
>
>> +             led1 {
>> +                     label = "led1:heart";
>
> Are the labels for this and the LEDs below related to the hardware?
> I mean, the label should preferrably come from the board documentation,
> or a label on the PCB next to the LED. Also they shouldn't represent
> any particular use case, so you should remove the ":heart" suffix.
>
>> +                     gpios = <&gpm4 0 1>;
>> +                     default-state = "off";
>> +                     linux,default-trigger = "heartbeat";
>> +             };
>
> style: Subnodes should be separated with blank lines.
>
> Otherwise the patch looks fine.
>
> Best regards,
> Tomasz
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/