linux-kernel - Re: How to reserve pci bus numbers for hotplug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQU-77q0CaCEkbH1sbMbnRWKpp3iNRNt-+qgQteOQ_mVhg@mail.gmail.com>
Date:	Sat, 14 Dec 2013 20:10:27 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Andreas Noever <andreas.noever@...il.com>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: How to reserve pci bus numbers for hotplug?

On Thu, Dec 12, 2013 at 11:56 AM, Andreas Noever
<andreas.noever@...il.com> wrote:
> On Thu, Dec 12, 2013 at 1:21 AM, Yinghai Lu <yinghai@...nel.org> wrote:
>> On Wed, Dec 11, 2013 at 3:37 PM, Andreas Noever
>> <andreas.noever@...il.com> wrote:
>>
>>> If I could get Linux to assign enough resources (bus numbers for now)
>>> then I could drop the acpi_osi parameter and make thunderbolt work
>>> after suspend... So, is there an easy way to fix this? (Quirks,
>>> reconfiguring bus number assignments from a platform driver, ...?)
>>
>> please check if busn_alloc at
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
>> for-pci-busn-alloc-3.14
>>
>> could help.
>
> It seems to help. The initial assignment looks good:
>            +-01.1-[05-9b]----00.0-[06-27]--+-00.0-[07]----00.0  Intel
> Corporation DSL3510 Thunderbolt Port [Cactus Ridge]
>            |                               +-03.0-[08-0f]--
>            |                               +-04.0-[10-17]--
>            |                               +-05.0-[18-1f]--
>            |                               \-06.0-[20-27]--
> After hotplug it looks like this:
>            +-01.1-[05-9b]----00.0-[06-29]--+-00.0-[07]----00.0  Intel
> Corporation DSL3510 Thunderbolt Port [Cactus Ridge]
>            |
> +-03.0-[08-11]----00.0-[09-11]----00.0-[0a-11]----00.0  Broadcom
> Corporation NetXtreme BCM57762 Gigabit Ethernet PCIe
>            |                               +-04.0-[10-17]--
>            |                               +-05.0-[18-1f]--
>            |                               \-06.0-[20-27]--
> (Note that the bridge numbers are not disjoint)

it should not extend to [08-11] or [06-29]

Please check attached patch that should address bus number wrong extending.
--- missed checking before going up one level ...wrong assumption ...

Thanks

Yinghai

View attachment "fix_probe_resource_assumption.patch" of type "text/x-patch" (1072 bytes)