linux-kernel - Re: [PATCH -next] staging: xillybus: fix error return code in xilly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000601cefa46$780f81e0$682e85a0$%han@samsung.com>
Date:	Mon, 16 Dec 2013 19:06:20 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Wei Yongjun' <weiyj.lk@...il.com>, gregkh@...uxfoundation.org,
	eli.billauer@...il.com
Cc:	yongjun_wei@...ndmicro.com.cn, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, 'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH -next] staging: xillybus: fix error return code in
 xilly_probe()

On Monday, December 16, 2013 2:51 PM, Wei Yongjun wrote:
> 
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix to return negative error code -EIO from the error handling
> case instead of 0.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/staging/xillybus/xillybus_pcie.c | 2 +-

It looks good.
Reviewed-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/xillybus/xillybus_pcie.c b/drivers/staging/xillybus/xillybus_pcie.c
> index 0564f97..51426d8 100644
> --- a/drivers/staging/xillybus/xillybus_pcie.c
> +++ b/drivers/staging/xillybus/xillybus_pcie.c
> @@ -168,9 +168,9 @@ static int xilly_probe(struct pci_dev *pdev,
>  	}
> 
>  	endpoint->registers = pci_iomap(pdev, 0, 128);
> -
>  	if (!endpoint->registers) {
>  		dev_err(endpoint->dev, "Failed to map BAR 0. Aborting.\n");
> +		rc = -EIO;
>  		goto failed_iomap0;
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/