lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1387191010.20076.66.camel@kazak.uk.xensource.com>
Date:	Mon, 16 Dec 2013 10:50:10 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Rashika Kheria <rashika.kheria@...il.com>
CC:	<linux-kernel@...r.kernel.org>, Wei Liu <wei.liu2@...rix.com>,
	<xen-devel@...ts.xenproject.org>, <netdev@...r.kernel.org>,
	<josh@...htriplett.org>
Subject: Re: [PATCH v2 9/9] drivers: net: Mark function
 xenvif_count_frag_slots() as static in netback.c

On Sat, 2013-12-14 at 18:02 +0530, Rashika Kheria wrote:
> This patch marks the function xenvif_count_frag_slots() in netback.c as
> static because they are not used outside this file.
> 
> Thus, it also removes the following warning in xen-netback/netback.c:
> drivers/net/xen-netback/netback.c:218:14: warning: no previous prototype for ‘xenvif_count_frag_slots’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Acked-by: Ian Campbell <ian.campbell@...rix.com>

> ---
> 
> This revision fixes the following issues of the previous revision:
> Change commit message subject
> 
>  drivers/net/xen-netback/netback.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 64f0e0d..9e4f399 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -215,7 +215,7 @@ struct xenvif_count_slot_state {
>  	bool head;
>  };
>  
> -unsigned int xenvif_count_frag_slots(struct xenvif *vif,
> +static unsigned int xenvif_count_frag_slots(struct xenvif *vif,
>  				     unsigned long offset, unsigned long size,
>  				     struct xenvif_count_slot_state *state)
>  {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ