linux-kernel - Re: [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJ1HTccZ0-QLAXnWOvMYHsO_GjzKtYbbqp7_0c_H3e_NA@mail.gmail.com>
Date:	Mon, 16 Dec 2013 07:46:47 -0600
From:	Rob Herring <robherring2@...il.com>
To:	dt.tangr@...il.com
Cc:	Linux USB List <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb

On Sat, Dec 14, 2013 at 9:35 PM,  <dt.tangr@...il.com> wrote:
> From: Daniel Tang <dt.tangr@...il.com>
>
>
> Signed-off-by: Daniel Tang <dt.tangr@...il.com>

A few minor things below. Otherwise:

Acked-by: Rob Herring <rob.herring@...xeda.com>

> ---
>  .../devicetree/bindings/usb/ci-hdrc-zevio.txt         |   17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
> new file mode 100644
> index 0000000..1a005eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
> @@ -0,0 +1,17 @@
> +* LSI Zevio USB OTG Controller
> +
> +Required properties:
> +- compatible: Should be "lsi,zevio-usb"
> +- reg: Should contain registers location and length
> +- interrupts: Should contain controller interrupt
> +
> +Recommended properies:

To be consistent, should be "optional" rather than recommended.

s/properies/properties/

> +- vbus-supply: regulator for vbus
> +
> +Examples:
> +               usb0: usb@...00000 {
> +                       reg = <0xB0000000 0x1000>;

lower case hex is preferred.

> +                       compatible = "lsi,zevio-usb";
> +                       interrupts = <8>;
> +                       vbus-supply = <&vbus_reg>;
> +               };
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/