linux-kernel - Re: [PATCH v5 1/2] mfd: cros ec: spi: Add delay for raising CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131216135050.GJ18769@lee--X1>
Date:	Mon, 16 Dec 2013 13:50:50 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Andrew Bresticker <abrestic@...omium.org>,
	Vincent Palatin <vpalatin@...omium.org>,
	Rhyland Klein <rklein@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] mfd: cros ec: spi: Add delay for raising CS

> From: Rhyland Klein <rklein@...dia.com>
> 
> The EC has specific timing it requires. Add support for an optional delay
> after raising CS to fix timing issues. This is configurable based on
> a DT property "google,cros-ec-spi-msg-delay".
> 
> If this property isn't set, then no delay will be added. However, if set
> it will cause a delay equal to the value passed to it to be inserted at
> the end of a transaction.
> 
> Signed-off-by: Rhyland Klein <rklein@...dia.com>
> Reviewed-by: Bernie Thompson <bhthompson@...omium.org>
> Reviewed-by: Andrew Bresticker <abrestic@...omium.org>
> Acked-by: Mark Rutland <mark.rutland@....com>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
> Changes in v5:
> - modify correct hunk to use 0 instead of '\0'
> - add Mark's Acked-by
> 
> Changes in v4:
> - unconditionally call cros_ec_spi_dt_probe() since the driver now
>   depends on OF
> 
> Changes in v3:
> - rename cros_ec_probe_spi_dt() to cros_ec_spi_dt_probe()
> - use 0 instead of '\0'
> 
> Changes in v2:
> - make property description more verbose
> 
>  Documentation/devicetree/bindings/mfd/cros-ec.txt |  9 +++++++
>  drivers/mfd/cros_ec_spi.c                         | 29 +++++++++++++++++++++++
>  2 files changed, 38 insertions(+)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/