linux-kernel - RE: [PATCH] mm/hugetlb: check for pte NULL pointer in __page_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131216142513.784A8E0090@blue.fi.intel.com>
Date:	Mon, 16 Dec 2013 16:25:13 +0200 (EET)
From:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:	Jianguo Wu <wujianguo@...wei.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	kirill.shutemov@...ux.intel.com,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, qiuxishi <qiuxishi@...wei.com>,
	Hanjun Guo <guohanjun@...wei.com>
Subject: RE: [PATCH] mm/hugetlb: check for pte NULL pointer in
 __page_check_address()

Jianguo Wu wrote:
> In __page_check_address(), if address's pud is not present,
> huge_pte_offset() will return NULL, we should check the return value.
> 
> Signed-off-by: Jianguo Wu <wujianguo@...wei.com>

Looks okay to me.

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

Have you triggered a crash there? Or just spotted by reading the code?

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/