linux-kernel - Re: [PATCH] mfd: (max8997) Handle the potential error for mfd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Dec 2013 15:09:37 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Laszlo Papp <lpapp@....org>
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: (max8997) Handle the potential error for
 mfd_add_devices

> I think you commented on the wrong patch. There has been a newer submitted.

No top posting please.

> > The $SUBJECT line is wrong. To see how a subsystem usually formats
> > theirs you must do something like `git log --oneline -- <subsystem>`.
> > And duplicate the format.
> >
> > Commit message?

These comments are still relevant, please re-post your patch with the
points rectified.

> >> Signed-off-by: Laszlo Papp <lpapp@....org>
> >> ---
> >>  drivers/mfd/max8997.c | 10 +++++-----
> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
> >> index 791aea3..c7cc235 100644
> >> --- a/drivers/mfd/max8997.c
> >> +++ b/drivers/mfd/max8997.c
> >> @@ -227,19 +227,19 @@ static int max8997_i2c_probe(struct i2c_client *i2c,
> >>       pm_runtime_set_active(max8997->dev);
> >>
> >>       max8997_irq_init(max8997);
> >> -
> >> -     mfd_add_devices(max8997->dev, -1, max8997_devs,
> >> +     ret = mfd_add_devices(max8997->dev, -1, max8997_devs,
> >>                       ARRAY_SIZE(max8997_devs),
> >>                       NULL, 0, NULL);
> >> +     if (ret < 0) {
> >> +             dev_err(dev, "cannot add mfd cells\n");
> >> +             goto err_mfd;
> >> +     }
> >
> > Have you tested this patch on h/w? Did you even compile it?

You must ensure to test your patches before sending to the MLs, it's
the very least we expect.

> >>       /*
> >>        * TODO: enable others (flash, muic, rtc, battery, ...) and
> >>        * check the return value
> >>        */
> >>
> >> -     if (ret < 0)
> >> -             goto err_mfd;
> >> -
> >>       /* MAX8997 has a power button input. */
> >>       device_init_wakeup(max8997->dev, pdata->wakeup);
> >>
> >

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/