linux-kernel - Re: [PATCH 1/2] ahci: bail out on ICH6 before using AHCI BAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131216154611.GE32509@htj.dyndns.org>
Date:	Mon, 16 Dec 2013 10:46:11 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ahci: bail out on ICH6 before using AHCI BAR

On Mon, Dec 16, 2013 at 11:34:21AM +0100, Paul Bolle wrote:
> The check for "combined mode" (which disables ahci support) on ICH6 is
> done after the first use of AHCI BAR. But if ahci is not enabled AHCI
> BAR is initialized to 0x00000000. (At least it is on the ICH6-M I tested
> this on. If I understand the datasheet correctly it should also be on
> ICH6R.) This apparently makes the call of
> pcim_iomap_regions_request_all() return -EINVAL. And we end up with
>     ahci: probe of 0000:00:1f.2 failed with error -22
> 
> (at warning level) in the logs.
> 
> So check for "combined mode" before calling
> pcim_iomap_regions_request_all().
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Applied to libata/for-3.13-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/