linux-kernel - Re: [PATCH] mfd: (max8997) Handle the potential error for mfd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMwXhPLU_2MUkJXgz-ab062bBjtcOEsvwNCSj0vG0eg9sr=rQ@mail.gmail.com>
Date:	Mon, 16 Dec 2013 16:13:47 +0000
From:	Laszlo Papp <lpapp@....org>
To:	Richard Weinberger <richard.weinberger@...il.com>
Cc:	Lee Jones <lee.jones@...aro.org>, sameo@...ux.intel.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: (max8997) Handle the potential error for mfd_add_devices

On Mon, Dec 16, 2013 at 4:05 PM, Richard Weinberger
<richard.weinberger@...il.com> wrote:
> On Mon, Dec 16, 2013 at 4:51 PM, Laszlo Papp <lpapp@....org> wrote:
>>>> > The $SUBJECT line is wrong. To see how a subsystem usually formats
>>>> > theirs you must do something like `git log --oneline -- <subsystem>`.
>>>> > And duplicate the format.
>>>> >
>>>> > Commit message?
>>>
>>> These comments are still relevant, please re-post your patch with the
>>> points rectified.
>>
>> I really do not understand how they relevant. "Commit message?" ->
>> What about it? It has a pretty clear commit message. Are you now just
>> picking nits about "foo:" vs "(foo)" in the short line?
>
> The commit message needs to have subject and a body.

Why? What advantage does that have in very simple cases like this?

> A good message body explains what the current situation is, why it is
> broken/has problems
> and how this patch fixes that.

The current commit message explains that in my opinion. Please bring
up real issues with it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/