[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <52AF47A4.6010501@wwwdotorg.org>
Date: Mon, 16 Dec 2013 11:34:12 -0700
From: Stephen Warren <swarren@...dotorg.org>
To: Hiroshi Doyu <hdoyu@...dia.com>, swarren@...dia.com,
will.deacon@....com, grant.likely@...aro.org,
thierry.reding@...il.com, robherring2@...il.com, joro@...tes.org
CC: mark.rutland@....com, devicetree@...r.kernel.org,
lorenzo.pieralisi@....com, linux-kernel@...r.kernel.org,
iommu@...ts.linux-foundation.org, galak@...eaurora.org,
linux-tegra@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv7 03/12] iommu/of: check if dependee iommu is ready or
not
On 12/12/2013 12:57 AM, Hiroshi Doyu wrote:
> IOMMU devices on the bus need to be poplulated first, then iommu
> master devices are done later.
>
> With CONFIG_OF_IOMMU, "iommus=" DT binding would be used to identify
> whether a device can be an iommu msater or not. If a device can, we'll
> defer to populate that device till an depending iommu device is
> populated.
> diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
> +int of_iommu_attach(struct device *dev)
> +{
> + const __be32 *cur, *end;
> + struct of_phandle_args args;
> +
> + of_property_for_each_phandle_with_args(dev->of_node, "iommus",
> + "#iommu-cells", 0, args, cur, end) {
> + if (!of_find_iommu_by_node(args.np))
> + return -EPROBE_DEFER;
I think that since of_find_iommu_by_node() should be calling
iommu_get(iommu), the error-case here should loop over the IOMMUs that
have successfully been acquired, and call iommu_put().
You'd also want to implement of_iommu_detach() or iommu_detach() to undo
the iommu_get()s that happen within this function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists