linux-kernel - Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Dec 2013 15:25:51 -0600
From:	Felipe Balbi <balbi@...com>
To:	Andreas Larsson <andreas@...sler.com>
CC:	<balbi@...com>, <linux-usb@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<software@...sler.com>
Subject: Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler
 GRUSBDC

Hi,

On Sun, Dec 15, 2013 at 11:24:12PM +0100, Andreas Larsson wrote:
> >>>Also, the way you're using thread IRQs is quite wrong. I can't let that
> >>>pass and get merged upstream, sorry.
> >>
> >>What is quite wrong? What is it that I need to fix?
> >
> >Ideally the hardirq handler should be usually to actually check if
> >$this_device generated the IRQ, that should involve reading a IRQSTATUS
> >register of some sort.
> >
> >Sure, check that IRQs are actually enabled, but you also need to read
> >STATUS register before waking the thread up.
> 
> I agree that that would be preferable. Unfortunately, the hardware
> lacks status register bits that indicates whether interrupts has been
> generated or not. That is why the only check is if interrupts are
> disabled, because that is the only sure way to know that the softirq
> handler does not need to go through everything.

so it seems, fair enough then. Keep it the way it is.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)