linux-kernel - Re: [PATCH v6 08/14] efi: export efi runtime memory mapping to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131217061347.GD6751@dhcp-16-126.nay.redhat.com>
Date:	Tue, 17 Dec 2013 14:13:47 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org,
	x86@...nel.org, mjg59@...f.ucam.org, hpa@...or.com,
	James.Bottomley@...senPartnership.com, vgoyal@...hat.com,
	ebiederm@...ssion.com, horms@...ge.net.au,
	kexec@...ts.infradead.org, bp@...en8.de, greg@...ah.com,
	toshi.kani@...com, akpm@...ux-foundation.org, mingo@...nel.org,
	msalter@...hat.com, leif.lindholm@...aro.org
Subject: Re: [PATCH v6 08/14] efi: export efi runtime memory mapping to sysfs

On 12/16/13 at 03:09pm, Matt Fleming wrote:
> On Mon, 16 Dec, at 05:30:29PM, Dave Young wrote:
> > @@ -899,6 +928,11 @@ void __init efi_enter_virtual_mode(void)
> >  		return;
> >  	}
> >  
> > +#ifdef CONFIG_EFI_RUNTIME_MAP
> > +	efi_runtime_map_setup(efi_runtime_map, nr_efi_runtime_map,
> > +			      boot_params.efi_info.efi_memdesc_size);
> > +#endif
> 
> [...]
> 
> > @@ -167,6 +167,12 @@ static int __init efisubsys_init(void)
> >  		goto err_unregister;
> >  	}
> >  
> > +#ifdef CONFIG_EFI_RUNTIME_MAP
> > +	error = efi_runtime_map_init(efi_kobj);
> > +	if (error)
> > +		goto err_remove_group;
> > +#endif
> 
> [...]
> 
> > @@ -876,4 +876,9 @@ int efivars_sysfs_init(void);
> >  
> >  #endif /* CONFIG_EFI_VARS */
> >  
> > +#ifdef CONFIG_EFI_RUNTIME_MAP
> > +int efi_runtime_map_init(struct kobject *);
> > +void efi_runtime_map_setup(void *, int, u32);
> > +#endif
> 
> I was thinking more along the lines of...

Previously I only call the function conditionally thus there's
compiler warning about "unused function" for the #else

unconditionally call it build will be ok. Will update this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/