linux-kernel - Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131217082118.GI12034@norris-Latitude-E6410>
Date:	Tue, 17 Dec 2013 00:21:18 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Wei Yongjun' <weiyj.lk@...il.com>,
	'David Woodhouse' <dwmw2@...radead.org>,
	'Bill Pemberton' <wfp5p@...ginia.edu>,
	'Artem Bityutskiy' <artem.bityutskiy@...ux.intel.com>,
	'Wei Yongjun' <yongjun_wei@...ndmicro.com.cn>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in
 au1550nd_probe()

On Tue, Nov 26, 2013 at 07:35:55PM -0800, Brian Norris wrote:
> On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote:
> > On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote:
> > > On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote:
> > > > --- a/drivers/mtd/nand/au1550nd.c
> > > > +++ b/drivers/mtd/nand/au1550nd.c
> > > > @@ -480,6 +480,8 @@ static int au1550nd_probe(struct platform_device *pdev)
> > > >
> > > >  	mtd_device_register(&ctx->info, pd->parts, pd->num_parts);
> > > >
> > > > +	platform_set_drvdata(pdev, ctx);
> > > > +
> > > 
> > > Personally, I'd choose to call platform_set_drvdata() earlier in the
> > > probe routine (e.g., immediately after its allocation), in case we end
> > > up calling platform_get_drvdata() from some sub-routine in the future.
> > 
> > Do you mean the following?
> > But, most drivers calls platform_set_drvdata() later in the probe routine.
> 
> I wouldn't say "most." An unscientific survey seemed to show some
> variation, with no clear pattern.

I'm just pushing the original patch, since this isn't really a big
issue.

Pushed to l2-mtd.git. I reworked the $subject, since this isn't really
about MIPS at all. Thanks Wei and Jingoo.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/