linux-kernel - Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131217093442.GE21999@twins.programming.kicks-ass.net>
Date:	Tue, 17 Dec 2013 10:34:42 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Richard Guy Briggs <rgb@...hat.com>
Cc:	Oleg Nesterov <oleg@...hat.com>, Eric Paris <eparis@...hat.com>,
	linux-kernel@...r.kernel.org, linux-audit@...hat.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding
 task->pid and task->tgid

On Mon, Dec 16, 2013 at 05:20:51PM -0500, Richard Guy Briggs wrote:

 >  static inline bool is_idle_task(const struct task_struct *p)
 >  {
 > -	return p->pid == 0;
 > +	return task_pid(p) == &init_struct_pid;
 >  }

> I'll stick with task_pid_nr(p) == 0.

We're going to probably switch to:

  return p->flags & PF_IDLE;

Soon, because people are playing silly tricks and want normal threads
to temporarily appear to be the idle thread (idle time injection).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/