linux-kernel - Re: [PATCH] mfd: max8997: Enforce mfd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131217132355.GG19810@lee--X1>
Date:	Tue, 17 Dec 2013 13:23:55 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Laszlo Papp <lpapp@....org>
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max8997: Enforce mfd_add_devices() return value
 check

On Tue, 17 Dec 2013, Laszlo Papp wrote:

> The original author provided a random return value check which is
> redundant and seemingly floating. This patch not only relocates
> the check so it is more clearly associated with the invokation of
> mfd_add_devices(), but provides a store for the error value. We
> also print a meaningful message on error before returning.
> 
> Signed-off-by: Laszlo Papp <lpapp@....org>
> ---
>  drivers/mfd/max8997.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/