linux-kernel - Re: [PATCH 2/2] drivers: sfi: Mark functions as static in sfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131217163525.GD737@leaf>
Date:	Tue, 17 Dec 2013 08:35:25 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
	sfi-devel@...plefirmware.org
Subject: Re: [PATCH 2/2] drivers: sfi: Mark functions as static in sfi_core.c

On Tue, Dec 17, 2013 at 06:04:50PM +0530, Rashika Kheria wrote:
> Mark functions sfi_map_table() and sfi_unmap_table() as static in
> sfi_core.c because they are not used outside this file.
> 
> This eliminates following warning in sfi_core.c:
> drivers/sfi/sfi_core.c:164:26: warning: no previous prototype for ‘sfi_map_table’ [-Wmissing-prototypes]
> drivers/sfi/sfi_core.c:192:6: warning: no previous prototype for ‘sfi_unmap_table’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/sfi/sfi_core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
> index 1e824fb..296db7a 100644
> --- a/drivers/sfi/sfi_core.c
> +++ b/drivers/sfi/sfi_core.c
> @@ -161,7 +161,7 @@ static int sfi_verify_table(struct sfi_table_header *table)
>   * Check for common case that we can re-use mapping to SYST,
>   * which requires syst_pa, syst_va to be initialized.
>   */
> -struct sfi_table_header *sfi_map_table(u64 pa)
> +static struct sfi_table_header *sfi_map_table(u64 pa)
>  {
>  	struct sfi_table_header *th;
>  	u32 length;
> @@ -189,7 +189,7 @@ struct sfi_table_header *sfi_map_table(u64 pa)
>   * Undoes effect of sfi_map_table() by unmapping table
>   * if it did not completely fit on same page as SYST.
>   */
> -void sfi_unmap_table(struct sfi_table_header *th)
> +static void sfi_unmap_table(struct sfi_table_header *th)
>  {
>  	if (!TABLE_ON_PAGE(syst_va, th, th->len))
>  		sfi_unmap_memory(th, TABLE_ON_PAGE(th, th, th->len) ?
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/