linux-kernel - RE: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37C7B99F5@ORSMSX103.amr.corp.intel.com>
Date:	Tue, 17 Dec 2013 17:35:46 +0000
From:	"Moore, Robert" <robert.moore@...el.com>
To:	Rashika Kheria <rashika.kheria@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"Zheng, Lv" <lv.zheng@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	Len Brown <lenb@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"josh@...htriplett.org" <josh@...htriplett.org>,
	"devel@...ica.org" <devel@...ica.org>
Subject: RE: [PATCH 05/11] drivers: acpi: Include appropriate header file in
 utstate.c

I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".

> -----Original Message-----
> From: Rashika Kheria [mailto:rashika.kheria@...il.com]
> Sent: Tuesday, December 17, 2013 1:22 AM
> To: linux-kernel@...r.kernel.org
> Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> acpi@...r.kernel.org; josh@...htriplett.org; devel@...ica.org
> Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> utstate.c
> 
> Include appropriate header file acutils.h in acpica/utstate.c because
> function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> condition of ACPI_FUTURE_USAGE.
> 
> This eliminates the following warning in utstate.c:
> drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> ---
>  drivers/acpi/acpica/utstate.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> index 03c4c2f..0920d23 100644
> --- a/drivers/acpi/acpica/utstate.c
> +++ b/drivers/acpi/acpica/utstate.c
> @@ -43,6 +43,7 @@
> 
>  #include <acpi/acpi.h>
>  #include "accommon.h"
> +#include "acutils.h"
> 
>  #define _COMPONENT          ACPI_UTILITIES
>  ACPI_MODULE_NAME("utstate")
> @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
>   * DESCRIPTION: Create a new state and push it
>   *
> 
> **************************************************************************
> ****/
> +#ifdef  ACPI_FUTURE_USAGE
>  acpi_status
>  acpi_ut_create_pkg_state_and_push(void *internal_object,
>  				  void *external_object,
> @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
>  	acpi_ut_push_generic_state(state_list, state);
>  	return (AE_OK);
>  }
> +#endif
> 
> 
> /*************************************************************************
> ******
>   *
> --
> 1.7.9.5