linux-kernel - Re: [PATCH 1/4] Create generic early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387305938.1979.166.camel@deneb.redhat.com>
Date:	Tue, 17 Dec 2013 13:45:38 -0500
From:	Mark Salter <msalter@...hat.com>
To:	Dave Young <dyoung@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Leif Lindholm <leif.lindholm@...aro.org>,
	Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/4] Create generic early_ioremap() support

On Mon, 2013-12-16 at 09:48 +0800, Dave Young wrote:
> On 11/27/13 at 09:44pm, Mark Salter wrote:
> > This patch copies generic bits of x86 early_ioremap() support
> > into a library for potential use by other architectures.
> > 
> > Signed-off-by: Mark Salter <msalter@...hat.com>
> > CC: Arnd Bergmann <arnd@...db.de>
> > CC: Ingo Molnar <mingo@...nel.org>
> > CC: linux-arch@...r.kernel.org
> > ---
> >  include/asm-generic/early_ioremap.h |  40 ++++++
> >  lib/Kconfig                         |   3 +
> >  lib/Makefile                        |   1 +
> >  lib/early_ioremap.c                 | 243
> ++++++++++++++++++++++++++++++++++++
> 
> I do not understand why these should go to lib/, I feel it's slightly better
> move them to mm/
> 
> ditto about lib/ioremap.c, ...
> 

I hadn't really thought about it. Putting these things in mm doesn't
sound unreasonable, but lib seems to have become the place for a lot
generic code which could also belong in mm, net, etc.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/