linux-kernel - Re: [PATCH 04/13] tick: Use timekeeping_cpu() to elect the CPU handling timekeeping duty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Dec 2013 15:55:18 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Stultz <john.stultz@...aro.org>,
	Alex Shi <alex.shi@...aro.org>,
	Kevin Hilman <khilman@...aro.org>
Subject: Re: [PATCH 04/13] tick: Use timekeeping_cpu() to elect the CPU
 handling timekeeping duty

On Tue, Dec 17, 2013 at 11:51:23PM +0100, Frederic Weisbecker wrote:
> Now that we have an API to determine if a CPU is allowed to handle
> timekeeping duty, use it now on timekeeper selection time for clarity.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Alex Shi <alex.shi@...aro.org>
> Cc: Kevin Hilman <khilman@...aro.org>

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> ---
>  kernel/time/tick-common.c | 2 +-
>  kernel/time/tick-sched.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
> index 64522ec..755dcd6 100644
> --- a/kernel/time/tick-common.c
> +++ b/kernel/time/tick-common.c
> @@ -163,7 +163,7 @@ static void tick_setup_device(struct tick_device *td,
>  		 * this cpu:
>  		 */
>  		if (tick_do_timer_cpu == TICK_DO_TIMER_BOOT) {
> -			if (!tick_nohz_full_cpu(cpu))
> +			if (tick_timekeeping_cpu(cpu))
>  				tick_do_timer_cpu = cpu;
>  			else
>  				tick_do_timer_cpu = TICK_DO_TIMER_NONE;
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index df6432d..ea0d411 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -118,7 +118,7 @@ static void tick_sched_do_timer(ktime_t now)
>  	 * jiffies_lock.
>  	 */
>  	if (unlikely(tick_do_timer_cpu == TICK_DO_TIMER_NONE)
> -	    && !tick_nohz_full_cpu(cpu))
> +	    && tick_timekeeping_cpu(cpu))
>  		tick_do_timer_cpu = cpu;
>  #endif
> 
> -- 
> 1.8.3.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/