linux-kernel - Re: [PATCH 1/3 v2] regulator: act8865: add PMIC act8865 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131218110631.GD28455@sirena.org.uk>
Date:	Wed, 18 Dec 2013 11:06:31 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
Cc:	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"vpalatin@...omium.org" <vpalatin@...omium.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"plagnioj@...osoft.com" <plagnioj@...osoft.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/3 v2] regulator: act8865: add PMIC act8865 driver

On Wed, Dec 18, 2013 at 03:11:12AM +0000, Yang, Wenyou wrote:

> > This is the wrong type for a voltage table but it looks like it
> > shouldn't be a voltage table at all - this looks like it should be
> > mapped as linear ranges.

> Change it, using unsigned int.

> It is not linear, can't be mapped as linear range. so using voltage table.

No, linear ranges with a plural - look at regulator_map_voltage_linear_range.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)