linux-kernel - Re: [PATCH 1/2] usb: usbtest: Add timetout to simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131218163445.GI4970@saruman.home>
Date:	Wed, 18 Dec 2013 10:37:44 -0600
From:	Felipe Balbi <balbi@...com>
To:	Huang Rui <ray.huang@....com>
CC:	Roger Quadros <rogerq@...com>, <gregkh@...uxfoundation.org>,
	<stern@...land.harvard.edu>, <balbi@...com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] usb: usbtest: Add timetout to simple_io()

On Wed, Dec 18, 2013 at 10:46:03PM +0800, Huang Rui wrote:
> Hi Roger,
> 
> On Wed, Dec 18, 2013 at 03:40:10PM +0530, Roger Quadros wrote:
> > Without a timetout some tests e.g. test_halt() can remain stuck forever.
> > 
> > Signed-off-by: Roger Quadros <rogerq@...com>
> > Reviewed-by: Felipe Balbi <balbi@...com>
> > ---
> >  drivers/usb/misc/usbtest.c | 14 +++++++++++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> > index b415282..6294e1b 100644
> > --- a/drivers/usb/misc/usbtest.c
> > +++ b/drivers/usb/misc/usbtest.c
> > @@ -10,6 +10,7 @@
> >  
> >  #include <linux/usb.h>
> >  
> > +#define SIMPLE_IO_TIMEOUT	10000	/* in milliseconds */
> >  
> 
> Only one question, how do you confirm the timeout value?

dude, it's just a timeout. It could be anything, really. 10 seconds is
just large enough value that would allow even the slowest scenarios
(host + device) to complete, while not being so slow that you would
wanna kill yourself after waiting for such a long time ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)