linux-kernel - Re: [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131218154516.GE16227@intel.com>
Date:	Wed, 18 Dec 2013 21:15:16 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	dmaengine@...r.kernel.org, josh@...htriplett.org
Subject: Re: [PATCH 2/2] drivers: dma: Include appropriate header file in
 dca.c

On Mon, Dec 16, 2013 at 03:44:39PM +0530, Rashika Kheria wrote:
> Includes an appropriate header file dma_v2.h in ioat/dca.c because
> functions ioat2_dca_init() and ioat3_dca_init() have their function
> declarations in dma_v2.h.
> 
> This eliminates the following warning in ioat/dca.c:
> drivers/dma/ioat/dca.c:410:22: warning: no previous prototype for ‘ioat2_dca_init’ [-Wmissing-prototypes]
> drivers/dma/ioat/dca.c:624:22: warning: no previous prototype for ‘ioat3_dca_init’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
Acked-by: Vinod Koul <vinod.koul@...el.com>

--
~Vinod

> ---
>  drivers/dma/ioat/dca.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/ioat/dca.c b/drivers/dma/ioat/dca.c
> index 9e84d5b..b158bba 100644
> --- a/drivers/dma/ioat/dca.c
> +++ b/drivers/dma/ioat/dca.c
> @@ -35,6 +35,7 @@
>  
>  #include "dma.h"
>  #include "registers.h"
> +#include "dma_v2.h"
>  
>  /*
>   * Bit 7 of a tag map entry is the "valid" bit, if it is set then bits 0:6
> -- 
> 1.7.9.5
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/