linux-kernel - Re: [PATCH 2/2] dma: pl08x: allow zero slave channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131218162852.GM16227@intel.com>
Date:	Wed, 18 Dec 2013 21:58:52 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dma: pl08x: allow zero slave channels

On Sat, Dec 14, 2013 at 12:16:23AM +0100, Linus Walleij wrote:
> It might happen that a platform wants to use its DMA engine for
> memcpy only, and then we have zero slave channels to initialize,
> so allow the slave initialization to return zero.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Applied, this one

--
~Vinod
> ---
>  drivers/dma/amba-pl08x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index ec4ee5c1fe9d..f68f1c1d560b 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -2167,7 +2167,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
>  	/* Register slave channels */
>  	ret = pl08x_dma_init_virtual_channels(pl08x, &pl08x->slave,
>  			pl08x->pd->num_slave_channels, true);
> -	if (ret <= 0) {
> +	if (ret < 0) {
>  		dev_warn(&pl08x->adev->dev,
>  			"%s failed to enumerate slave channels - %d\n",
>  				__func__, ret);
> -- 
> 1.8.3.1
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/