linux-kernel - RE: [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Dec 2013 18:22:55 +0000
From:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
To:	Rashika Kheria <rashika.kheria@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Matt Porter <mporter@...nel.crashing.org>,
	"josh@...htriplett.org" <josh@...htriplett.org>
Subject: RE: [PATCH 2/3] drivers: rapidio: Include appropriate header file
 in rio-driver.c

On Sat, Dec 14, 2013 at 7:50AM, Rashika Kheria wrote:
> Subject: [PATCH 2/3] drivers: rapidio: Include appropriate header file
> in rio-driver.c
> 
> This patch includes the header file linux/rio_drv.h in rio-driver.c
> because functions rio_dev_get(), rio_dev_put(), rio_register_driver()
> and rio_unregister_driver() have their prototype declarations in
> linux/rio_drv.h.
> 
> Thus, it also eliminates the following warnings in rio-driver.c:
> 
> drivers/rapidio/rio-driver.c:57:17: warning: no previous prototype for
> ‘rio_dev_get’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:74:6: warning: no previous prototype for
> ‘rio_dev_put’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:143:5: warning: no previous prototype for
> ‘rio_register_driver’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:162:6: warning: no previous prototype for
> ‘rio_unregister_driver’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> ---
>  drivers/rapidio/rio-driver.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/rapidio/rio-driver.c b/drivers/rapidio/rio-
> driver.c
> index c9ae692..df73419 100644
> --- a/drivers/rapidio/rio-driver.c
> +++ b/drivers/rapidio/rio-driver.c
> @@ -13,6 +13,7 @@
>  #include <linux/init.h>
>  #include <linux/module.h>
>  #include <linux/rio.h>
> +#include <linux/rio_drv.h>
>  #include <linux/rio_ids.h>
> 
>  #include "rio.h"
> --
> 1.7.9.5

Acked-by: Alexandre Bounine <alexandre.bounine@....com>