linux-kernel - Re: [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Dec 2013 10:40:14 -0800
From:	josh@...htriplett.org
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <eduardo.valentin@...com>,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH] drivers: thermal: Mark function as static in
 x86_pkg_temp_thermal.c

On Wed, Dec 18, 2013 at 11:16:02PM +0530, Rashika Kheria wrote:
> Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c
> because it is not used outside this file.
> 
> This eliminates the following warning in x86_pkg_temp_thermal.c:
> drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/thermal/x86_pkg_temp_thermal.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/x86_pkg_temp_thermal.c b/drivers/thermal/x86_pkg_temp_thermal.c
> index 7722cb9..972e1c7 100644
> --- a/drivers/thermal/x86_pkg_temp_thermal.c
> +++ b/drivers/thermal/x86_pkg_temp_thermal.c
> @@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
>  	return 0;
>  }
>  
> -int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> +static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
>  							unsigned long temp)
>  {
>  	u32 l, h;
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/