linux-kernel - Re: [PATCH] mm,numa,THP: initialize hstate for THP page size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B21FC7.7070905@redhat.com>
Date:	Wed, 18 Dec 2013 17:20:55 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, Chao Yang <chayang@...hat.com>,
	linux-mm@...ck.org, aarcange@...hat.com, mgorman@...e.de,
	Veaceslav Falico <vfalico@...hat.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	David Rientjes <rientjes@...gle.com>,
	Michel Lespinasse <walken@...gle.com>,
	Michal Hocko <mhocko@...e.cz>
Subject: Re: [PATCH] mm,numa,THP: initialize hstate for THP page size

On 12/18/2013 05:08 PM, Andrew Morton wrote:
> On Wed, 18 Dec 2013 17:03:14 -0500 Rik van Riel <riel@...hat.com> wrote:
>
>> When hugetlbfs is started with a non-default page size, it is
>> possible that no hstate is initialized for the page sized used
>> by transparent huge pages.
>>
>> This causes copy_huge_page to crash on a null pointer. Make
>> sure we always have an hstate initialized for the page sized
>> used by THP.
>>
>
> A bit more context is needed here please - so that people can decide
> which kernel version(s) need patching.

That is a good question.

Looking at the git log, this might go back to 2008,
when the hugepagesz and default_hugepagesz boot
options were introduced.

Of course, back then there was no way to use 2MB
pages together with 1GB pages.

That did not come until transparent huge pages were
introduced back in 2011.  It looks like the transparent
huge page code avoids the bug (accidentally?) by calling
copy_user_huge_page when COWing a THP, instead of
copy_huge_page, this avoids iterating over hstates[].

That means it should not be possible for the bug to
have been triggered until the numa balancing code
got merged.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/