linux-kernel - Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131219183529.GB17741@jtriplet-mobl1>
Date:	Thu, 19 Dec 2013 10:35:29 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Matthias Beyer <mail@...ermatthias.de>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Hans de Goede <hdegoede@...hat.com>,
	linux-usb <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 1/7] drivers: usb: Include appropriate header file in
 hcd.c

On Thu, Dec 19, 2013 at 05:33:09PM -0000, David Laight wrote:
> > > These warning are non-default GCC warnings. These can be seen either
> > > by adding W=1 while running make (i.e. make W=1) or adding
> > > -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.
> > 
> > By default, we don't care about 'W=1' warnings, as no one sees them, and
> > they don't matter.
> 
> -Wmissing-prototypes really ought to be defined.

Yeah, that's the plan; this volume of patches should make it
sufficiently low-noise to allow turning it on by default.

> Some of the other warning are a little more pedantic, the most annoying
> is -Wsign-compare.  OTOH a lot of code out there is clean enough to build
> without any warnings and with a moderate amount of pedantry from the compiler.
> 
> OTOH just including extra headers isn't ideal - it can considerably
> slow down the compilation time. There are many subsystems that don't
> really separate their internal headers from their external ones.

There's a benefit to doing so, though: it ensures that the prototypes in
the header stay in sync with the definition.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/