linux-kernel - Re: [PATCH 3/3] drivers: pcmcia: Include appropriate header file in cardbus.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Dec 2013 11:53:49 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yinghai Lu <yinghai@...nel.org>,
	linux-pcmcia@...ts.infradead.org, josh@...htriplett.org
Subject: Re: [PATCH 3/3] drivers: pcmcia: Include appropriate header file in cardbus.c

On Thu, Dec 19, 2013 at 11:14 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Thu, Dec 19, 2013 at 1:36 AM, Rashika Kheria
> <rashika.kheria@...il.com> wrote:
>> Include appropriate header file cs_internal.h in cardbus.c because
>> functions cb_alloc() and cb_free() have their prototype declarations in
>> cs_internal.h.
>>
>> This eliminates the following warnings in cardbus.c:
>> drivers/pcmcia/cardbus.c:67:11: warning: no previous prototype for ‘cb_alloc’ [-Wmissing-prototypes]
>> drivers/pcmcia/cardbus.c:105:6: warning: no previous prototype for ‘cb_free’ [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
>> Reviewed-by: Josh Triplett <josh@...htriplett.org>
>
> Applied to my pci/misc branch for v3.14, thanks!

I dropped this for now because it breaks my build:

  CC      drivers/pcmcia/cardbus.o
In file included from drivers/pcmcia/cardbus.c:28:0:
drivers/pcmcia/cs_internal.h:164:9: error: unknown type name ‘cisdata_t’
drivers/pcmcia/cs_internal.h:171:9: error: unknown type name ‘cisdata_t’
drivers/pcmcia/cs_internal.h:171:25: error: unknown type name ‘cisparse_t’
drivers/pcmcia/cs_internal.h:172:28: error: unknown type name ‘tuple_t’
drivers/pcmcia/cs_internal.h:173:7: error: unknown type name ‘cisparse_t’
drivers/pcmcia/cs_internal.h:177:4: error: unknown type name ‘tuple_t’
drivers/pcmcia/cs_internal.h:180:4: error: unknown type name ‘tuple_t’
drivers/pcmcia/cs_internal.h:182:52: error: unknown type name ‘tuple_t’
make[2]: *** [drivers/pcmcia/cardbus.o] Error 1

My .config is attached.

Bjorn

Download attachment ".config" of type "application/octet-stream" (92023 bytes)