linux-kernel - Re: [PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131219054651.GD19091@hr-dev.amd.com>
Date:	Thu, 19 Dec 2013 13:46:51 +0800
From:	Huang Rui <ray.huang@....com>
To:	Roger Quadros <rogerq@...com>
CC:	<gregkh@...uxfoundation.org>, <stern@...land.harvard.edu>,
	<balbi@...com>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] usb: usbtest: Always clear halt else further tests
 will fail

On Thu, Dec 19, 2013 at 12:01:47PM +0800, Huang Rui wrote:
> On Wed, Dec 18, 2013 at 03:40:11PM +0530, Roger Quadros wrote:
> > In test_halt() we set an endpoint halt condition and return on halt verification
> > failure, then the enpoint will remain halted and all further tests related
                      ^^^^^^^
> > to that enpoint will fail. This is because we don't tackle endpoint halt error condition
            ^^^^^^^
BTW, please fix these typo.

Thanks,
Rui

> > in any of the tests. To avoid that situation, make sure to clear the
> > halt condition before exiting test_halt().
> > 
> > Signed-off-by: Roger Quadros <rogerq@...com>
> > Reviewed-by: Felipe Balbi <balbi@...com>
> 
> Acked-by: Huang Rui <ray.huang@....com>
> 
> > ---
> >  drivers/usb/misc/usbtest.c | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> > index 6294e1b..300b726 100644
> > --- a/drivers/usb/misc/usbtest.c
> > +++ b/drivers/usb/misc/usbtest.c
> > @@ -1545,8 +1545,17 @@ static int test_halt(struct usbtest_dev *tdev, int ep, struct urb *urb)
> >  		return retval;
> >  	}
> >  	retval = verify_halted(tdev, ep, urb);
> > -	if (retval < 0)
> > +	if (retval < 0) {
> > +		int ret;
> > +
> > +		/* clear halt anyways, else further tests will fail */
> > +		ret = usb_clear_halt(urb->dev, urb->pipe);
> > +		if (ret)
> > +			ERROR(tdev, "ep %02x couldn't clear halt, %d\n",
> > +			      ep, ret);
> > +
> >  		return retval;
> > +	}
> >  
> >  	/* clear halt (tests API + protocol), verify it worked */
> >  	retval = usb_clear_halt(urb->dev, urb->pipe);
> > -- 
> > 1.8.3.2
> > 
> > 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/