linux-kernel - Re: [tip:x86/idle] x86, acpi, idle: Restructure the mwait idle routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B35369.6070208@zytor.com>
Date:	Thu, 19 Dec 2013 12:13:29 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	mingo@...nel.org, linux-kernel@...r.kernel.org,
	arjan@...ux.intel.com, peterz@...radead.org, rui.zhang@...el.com,
	bitbucket@...ine.de, rafael.j.wysocki@...el.com, lenb@...nel.org,
	tglx@...utronix.de, jacob.jun.pan@...ux.intel.com,
	hpa@...ux.intel.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/idle] x86, acpi, idle: Restructure the mwait idle routines

On 12/19/2013 12:09 PM, tip-bot for Peter Zijlstra wrote:
> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
> index 8f181b3..e8275f2 100644
> --- a/drivers/thermal/intel_powerclamp.c
> +++ b/drivers/thermal/intel_powerclamp.c
> @@ -438,9 +438,7 @@ static int clamp_thread(void *arg)
>  			 */
>  			local_touch_nmi();
>  			stop_critical_timings();
> -			__monitor((void *)&current_thread_info()->flags, 0, 0);
> -			cpu_relax(); /* allow HT sibling to run */
> -			__mwait(eax, ecx);
> +			mwait_idle_with_hints(eax, ecx);
>  			start_critical_timings();
>  			atomic_inc(&idle_wakeup_counter);
>  		}
> 

Should this cpu_relax() be in the common code as well?

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/