linux-kernel - Re: [PATCH 29/40] mips: Replace __get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1312191506370.17603@nuc>
Date:	Thu, 19 Dec 2013 15:10:45 -0600 (CST)
From:	Christoph Lameter <cl@...ux.com>
To:	David Daney <ddaney.cavm@...il.com>
cc:	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH 29/40] mips: Replace __get_cpu_var uses

On Thu, 19 Dec 2013, David Daney wrote:

> > 16:07:58.244398747 -0600
> > @@ -43,7 +43,7 @@ DECLARE_PER_CPU(struct mips_fpu_emulator
> >   #define MIPS_FPU_EMU_INC_STATS(M)					\
> >   do {
> > \
> >   	preempt_disable();						\
> > -	__local_inc(&__get_cpu_var(fpuemustats).M);			\
> > +	__this_cpu_inc(fpuemustats.M);					\
> >   	preempt_enable();						\
> >   } while (0)
> >
>
> Something seems to be incorrect in this bit.

Hrmm.. yes this is a local_t so the this_cpu_inc would not work unless
fpuemustats is defined differently.

Use

__local_inc(this_cpu_ptr(fpuemustats.M);

instead until then.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/