linux-kernel - Re: [PATCH v3 2/8] drivers: net: Mark functions as static in qlcnic_83xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Dec 2013 18:52:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rashika.kheria@...il.com
Cc:	linux-kernel@...r.kernel.org, himanshu.madhani@...gic.com,
	rajesh.borundia@...gic.com, shahed.shaikh@...gic.com,
	jitendra.kalsaria@...gic.com, sony.chacko@...gic.com,
	sucheta.chakraborty@...gic.com, linux-driver@...gic.com,
	netdev@...r.kernel.org, josh@...htriplett.org
Subject: Re: [PATCH v3 2/8] drivers: net: Mark functions as static in
 qlcnic_83xx_hw.c

From: Rashika Kheria <rashika.kheria@...il.com>
Date: Thu, 19 Dec 2013 14:18:11 +0530

> This patch marks the function qlcnic_83xx_clear_legacy_intr_mask(),
> qlcnic_83xx_set_legacy_intr_mask() and
> qlcnic_83xx_enable_legacy_msix_mbx_intr() in qlcnic_83xx_hw.c as static
> because they are not used outside this file.
> 
> Thus, it also removes the following warnings
> in ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:318:13: warning: no previous prototype for ‘qlcnic_83xx_clear_legacy_intr_mask’ [-Wmissing-prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:323:13: warning: no previous prototype for ‘qlcnic_83xx_set_legacy_intr_mask’ [-Wmissing-prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:343:13: warning: no previous prototype for ‘qlcnic_83xx_enable_legacy_msix_mbx_intr’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Applied.