linux-kernel - RE: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1387443585.2101.216.camel@kjgkr>
Date:	Thu, 19 Dec 2013 17:59:45 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Chao Yu <chao2.yu@...sung.com>
Cc:	'Gu Zheng' <guz.fnst@...fujitsu.com>,
	'fsdevel' <linux-fsdevel@...r.kernel.org>,
	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'f2fs' <linux-f2fs-devel@...ts.sourceforge.net>
Subject: RE: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into
 __bio_alloc

Hi Gu,

I agreed with Chao.
It is more readable to use something like "is_read" instead of "rw".
Thanks,

2013-12-19 (목), 09:23 +0800, Chao Yu:
> Hi Gu,
> 
> > -----Original Message-----
> > From: Gu Zheng [mailto:guz.fnst@...fujitsu.com]
> > Sent: Wednesday, December 18, 2013 6:29 PM
> > To: Kim
> > Cc: fsdevel; linux-kernel; f2fs
> > Subject: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc
> > 
> > Move all the bio initialization into __bio_alloc, and some minor cleanups are
> > also added.
> 
> Looks more neat!
> 
> > @@ -178,17 +179,16 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct page *page,
> >  			block_t blk_addr, struct f2fs_io_info *fio)
> >  {
> >  	enum page_type btype = PAGE_TYPE_OF_BIO(fio->type);
> > -	struct block_device *bdev = sbi->sb->s_bdev;
> >  	struct f2fs_bio_info *io;
> > -	int bio_blocks;
> > +	int rw = is_read_io(fio->rw);
> 
> Maybe it's more neat to use 'is_read' to instead of 'rw'.
> 
> Thanks
> 

-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/