linux-kernel - Re: [PATCH] Revert "ARC: Add guard macro to uapi/asm/unistd.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUYuf8+d+ahiHW4g-wfmjXOuR1T_g9LQ3_L3zy3ON=URw@mail.gmail.com>
Date:	Thu, 19 Dec 2013 13:42:08 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Francois Bedard <Francois.Bedard@...opsys.com>,
	David Howells <dhowells@...hat.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] Revert "ARC: Add guard macro to uapi/asm/unistd.h"

On Thu, Dec 19, 2013 at 1:34 PM, Chen Gang <gang.chen.5i5j@...il.com> wrote:
> On 12/19/2013 07:13 PM, Vineet Gupta wrote:
>> This reverts commit 97bc386fc12deeb41d5bff33548e3002b258d4e0.
>>
>> Generic syscall table generator relies on ARCH unistd.h as follows:
>>
>>       void *sys_call_table[NR_syscalls] = {
>>               [0 ... NR_syscalls-1] = sys_ni_syscall,
>>       #include <asm/unistd.h>
>>       };
>>
>> And turns out that prior dependencies already include that header by
>> the time preprocessor hits the above. Meaning ARCH unistd.h needs to be
>> able to included twice.
>
> OK, thanks, it sounds reasonable to me.
>
> But why many other architectures contents these guard macros? (arm, sh,
> blackfin, cris, frv, ia64, m32r, m68k, mips, s390, microblaze, mn10300,
> parisc, powerpc, sparc, x86). Do they need improvement too?

Those architectures don't use the generic syscall table generator.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/