| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Dec 2013 08:34:25 -0500
From: Jeff Layton <jlayton@...hat.com>
To: linux-fsdevel@...r.kernel.org
Cc: nfs-ganesha-devel@...ts.sourceforge.net,
samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: [PATCH v4 13/13] locks: add new "private" lock type that is owned by the filp
Due to some unfortunate history, POSIX locks have very strange and
unhelpful semantics. The thing that usually catches people by surprise
is that they are dropped whenever the process closes any file descriptor
associated with the inode.
This is extremely problematic for people developing file servers that
need to implement byte-range locks. Developers often need a "lock
management" facility to ensure that file descriptors are not closed
until all of the locks associated with the inode are finished.
Additionally, "classic" POSIX locks are owned by the process. Locks
taken between threads within the same process won't conflict with one
another, which renders them useless for synchronization between threads.
This patchset adds a new type of lock that attempts to address these
issues. These locks conflict with classic POSIX read/write locks, but
have semantics that are more like BSD locks with respect to inheritance
and behavior on close.
This is implemented primarily by changing how fl_owner field is set for
these locks. Instead of having them owned by the files_struct of the
process, they are instead owned by the filp on which they were acquired.
Thus, they are inherited across fork() and are only released when the
last reference to a filp is put.
These new semantics prevent them from being merged with classic POSIX
locks, even if they are acquired by the same process. These locks will
also conflict with classic POSIX locks even if they are acquired by
the same process or on the same file descriptor.
Signed-off-by: Jeff Layton <jlayton@...hat.com>
---
fs/locks.c | 34 ++++++++++++++++++++++++++++++++--
include/uapi/asm-generic/fcntl.h | 16 ++++++++++++++++
2 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 013b177..bd2d824 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -381,7 +381,6 @@ static int flock64_to_posix_lock(struct file *filp, struct file_lock *fl,
} else
fl->fl_end = OFFSET_MAX;
- fl->fl_owner = current->files;
fl->fl_pid = current->tgid;
fl->fl_file = filp;
fl->fl_flags = FL_POSIX;
@@ -391,16 +390,45 @@ static int flock64_to_posix_lock(struct file *filp, struct file_lock *fl,
/* Ensure that fl->fl_filp has compatible f_mode */
switch (l->l_type) {
case F_RDLCK:
+ case F_RDLCKP:
if (!(filp->f_mode & FMODE_READ))
return -EBADF;
break;
case F_WRLCK:
+ case F_WRLCKP:
if (!(filp->f_mode & FMODE_WRITE))
return -EBADF;
break;
}
- return assign_type(fl, l->l_type);
+ /*
+ * FL_FILE_PVT locks are "owned" by the filp upon which they were
+ * acquired, regardless of what task is dealing with them. Set the
+ * fl_owner appropriately and flag them as private.
+ */
+ switch(l->l_type) {
+ case F_RDLCKP:
+ fl->fl_owner = (fl_owner_t)filp;
+ fl->fl_type = F_RDLCK;
+ fl->fl_flags |= FL_FILE_PVT;
+ break;
+ case F_WRLCKP:
+ fl->fl_owner = (fl_owner_t)filp;
+ fl->fl_type = F_WRLCK;
+ fl->fl_flags |= FL_FILE_PVT;
+ break;
+ case F_UNLCKP:
+ fl->fl_owner = (fl_owner_t)filp;
+ fl->fl_type = F_UNLCK;
+ fl->fl_flags |= FL_FILE_PVT;
+ break;
+ default:
+ /* Any other POSIX lock is owned by the file_struct */
+ fl->fl_owner = current->files;
+ return assign_type(fl, l->l_type);
+ }
+
+ return 0;
}
/* Verify a "struct flock" and copy it to a "struct file_lock" as a POSIX
@@ -2207,6 +2235,8 @@ void locks_remove_file(struct file *filp)
if (!inode->i_flock)
return;
+ locks_remove_posix(filp, (fl_owner_t)filp);
+
if (filp->f_op->flock) {
struct file_lock fl = {
.fl_pid = current->tgid,
diff --git a/include/uapi/asm-generic/fcntl.h b/include/uapi/asm-generic/fcntl.h
index 36025f7..25eb7be 100644
--- a/include/uapi/asm-generic/fcntl.h
+++ b/include/uapi/asm-generic/fcntl.h
@@ -151,6 +151,22 @@ struct f_owner_ex {
#define F_UNLCK 2
#endif
+/*
+ * fd "private" POSIX locks.
+ *
+ * Usually POSIX locks held by a process are released on *any* close and are
+ * not inherited across a fork().
+ *
+ * These lock types will conflict with normal POSIX locks, but are "owned"
+ * by the opened file, not the process. This means that they are inherited
+ * across fork() like BSD (flock) locks, and they are only released
+ * automatically when the last reference to the the open file against which
+ * they were acquired is put.
+ */
+#define F_RDLCKP 5
+#define F_WRLCKP 6
+#define F_UNLCKP 7
+
/* for old implementation of bsd flock () */
#ifndef F_EXLCK
#define F_EXLCK 4 /* or 3 */
--
1.8.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists