linux-kernel - Re: [PATCH] usb/gadget: should use u16 type variable to store MaxPower

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131219144848.GF3985@saruman.home>
Date:	Thu, 19 Dec 2013 08:48:48 -0600
From:	Felipe Balbi <balbi@...com>
To:	"Du, ChangbinX" <changbinx.du@...el.com>
CC:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb/gadget: should use u16 type variable to store
 MaxPower

On Tue, Dec 17, 2013 at 11:47:42AM +0000, Du, ChangbinX wrote:
> From 7e827a0d300e084f74c65122baa5e3193f9a7f18 Mon Sep 17 00:00:00 2001
> From: "Du, Changbin" <changbinx.du@...el.com>
> Date: Mon, 16 Dec 2013 20:32:13 +0800
> Subject: [PATCH] usb/gadget: should use u16 type variable to store MaxPower
> 
> The MaxPower field is of u16 type. So using u8 type variable can break

Alright I see we need some cleanups around that area in the gadget
framework.

Descriptor is always a u8, no question about it. But
usb_gadget_vbus_draw() receives a u32 as argument, while
struct usb_configuration defines it as u16.

I'll take this patch anyway, as it solves a real issue. Thanks

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)