linux-kernel - Re: [PATCH v2 2/3] usb: musb: add support for JZ4740 usb device controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131219153608.GK3985@saruman.home>
Date:	Thu, 19 Dec 2013 09:36:08 -0600
From:	Felipe Balbi <balbi@...com>
To:	Apelete Seketeli <apelete@...eteli.net>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Felipe Balbi <balbi@...com>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2 2/3] usb: musb: add support for JZ4740 usb device
 controller

On Wed, Dec 18, 2013 at 12:56:00AM +0100, Apelete Seketeli wrote:
> Add support for Ingenic JZ4740 USB Device Controller through a
> specific musb glue layer.
> 
> The platform data already available in tree for that USB Device
> Controller was previously used by an out-of-tree USB gadget driver
> which was not relying on the musb driver and was written by Ingenic
> and the Qi-Hardware community.
> 
> JZ4740 UDC not being OTG compatible and missing some hardware
> registers, this musb glue layer is written from scratch to be used in
> gadget mode only and take silicon design specifics into account.
> 
> Signed-off-by: Apelete Seketeli <apelete@...eteli.net>
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> ---
>  arch/mips/include/asm/mach-jz4740/platform.h |    1 +
>  arch/mips/jz4740/board-qi_lb60.c             |    1 +
>  arch/mips/jz4740/platform.c                  |   40 +++--
>  drivers/usb/musb/Kconfig                     |    8 +-
>  drivers/usb/musb/Makefile                    |    1 +
>  drivers/usb/musb/jz4740.c                    |  201 ++++++++++++++++++++++++++

you can split this patch. drivers part has no dependency on arch part.

> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index 57dfc0c..a45ed15 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -93,6 +93,12 @@ config USB_MUSB_BLACKFIN
>  config USB_MUSB_UX500
>  	tristate "Ux500 platforms"
>  
> +config USB_MUSB_JZ4740
> +	tristate "JZ4740"
> +	depends on MACH_JZ4740

add || COMPILE_TEST

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)