linux-kernel - Re: [PATCH 22/38] sound: ac97: add missing put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h8uvgstmf.wl%tiwai@suse.de>
Date:	Thu, 19 Dec 2013 17:17:12 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Levente Kurusa <levex@...ux.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Ondrej Zary <linux@...nbow-software.org>,
	Yacine Belkadi <yacine.belkadi.1@...il.com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 22/38] sound: ac97: add missing put_device call

At Thu, 19 Dec 2013 16:03:33 +0100,
Levente Kurusa wrote:
> 
> This is required so that we give up the last reference to the device.
> 
> Signed-off-by: Levente Kurusa <levex@...ux.com>

Hmm, I see no merit by this patch.  It's an error path and the device
is referenced from nowhere, thus we don't care its refcount any longer
from there.  Any missing point?


thanks,

Takashi

> ---
>  sound/pci/ac97/ac97_codec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> index bf578ba2..55186f8 100644
> --- a/sound/pci/ac97/ac97_codec.c
> +++ b/sound/pci/ac97/ac97_codec.c
> @@ -1964,6 +1964,7 @@ static int snd_ac97_dev_register(struct snd_device *device)
>  		     snd_ac97_get_short_name(ac97));
>  	if ((err = device_register(&ac97->dev)) < 0) {
>  		snd_printk(KERN_ERR "Can't register ac97 bus\n");
> +		put_device(&ac97->dev);
>  		ac97->dev.bus = NULL;
>  		return err;
>  	}
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/