linux-kernel - Re: [PATCH] don't select EFI from certain special ACPI drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131219165643.GA30382@gmail.com>
Date:	Thu, 19 Dec 2013 17:56:43 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Tony Luck <tony.luck@...el.com>
Cc:	Matt Fleming <matt.fleming@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jan Beulich <JBeulich@...e.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] don't select EFI from certain special ACPI drivers


* Tony Luck <tony.luck@...el.com> wrote:

> On Wed, Dec 18, 2013 at 12:04 AM, Jan Beulich <JBeulich@...e.com> wrote:
> >>>> On 17.12.13 at 23:34, "Luck, Tony" <tony.luck@...el.com> wrote:
> >>>  No, it hasn't. But I explicitly checked the relevant EFI=n and EFI=y
> >>> cases.
> >>
> >> I pushed your patch into my "next" tree - the robots will notice soon and
> >> send us e-mail if they find any issues.
> >
> > Thanks, Tony. I'm afraid though that fixing this only in 3.14 would
> > be a little late: Any "select" in a Kconfig results in the user not being
> > asked again when that "select" goes away, so people having got EFI
> > forcibly enabled in 3.13 and updating their configs to 3.14 would
> > then need to remember to manually disable CONFIG_EFI again (of
> > course that's already true for anyone using 3.13-rc?, but those
> > should mostly be people more knowledgeable than folks just
> > consuming final releases).
> >
> > I think it should generally be the exception to "select" options that
> > have visible prompts (i.e. are user configurable).
> 
> Ingo: Jan makes a good point that people running "make oldconfig"
> may get suckered into selecting CONFIG_EFI when they don't really
> need it.  I've not seen any complaints from the robot randconfig testers,
> so this patch is:
> 
> Acked-by: Tony Luck <tony.luck@...el.com>
> 
> Can you push it to Linus before 3.13-final releases?

Ok, agreed, I've queued it up in the tip:x86/urgent tree.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/