linux-kernel - Re: [PATCH v3] libata, freezer: avoid block device removal while system is frozen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131219172412.GA22725@htj.dyndns.org>
Date:	Thu, 19 Dec 2013 12:24:12 -0500
From:	Tejun Heo <tj@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Jens Axboe <axboe@...nel.dk>, tomaz.solc@...lix.org,
	aaron.lu@...el.com, linux-kernel@...r.kernel.org,
	Oleg Nesterov <oleg@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH v3] libata, freezer: avoid block device removal while
 system is frozen

Hello,

On Wed, Dec 18, 2013 at 11:08:41PM +0100, Rafael J. Wysocki wrote:
> > This is something fundamentally broken.  For now,
> > implement a funny workaround in libata - just avoid doing block device
> > hot[un]plug while the system is frozen.  Kernel engineering at its
> > finest.  :(
> > 
> > v2: Add EXPORT_SYMBOL_GPL(pm_freezing) for cases where libata is built
> >     as a module.
> > 
> > v3: Comment updated and polling interval changed to 10ms as suggested
> >     by Rafael.
> 
> This one is fine by my FWIW.

Applied to libata/for-3.13-fixes.  I liberally added your reviewed-by
from the above response.  Please let me know if I should remove it.
I'll push it out to Linus after it spends a couple days in -next.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/