linux-kernel - RE: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B74B9@saturn3.aculab.com>
Date:	Thu, 19 Dec 2013 17:33:09 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Rashika Kheria" <rashika.kheria@...il.com>
Cc:	"Linux-Kernel" <linux-kernel@...r.kernel.org>,
	"Alan Stern" <stern@...land.harvard.edu>,
	"Matthias Beyer" <mail@...ermatthias.de>,
	"Sarah Sharp" <sarah.a.sharp@...ux.intel.com>,
	"Hans de Goede" <hdegoede@...hat.com>,
	"linux-usb" <linux-usb@...r.kernel.org>,
	"Josh Triplett" <josh@...htriplett.org>
Subject: RE: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

> > These warning are non-default GCC warnings. These can be seen either
> > by adding W=1 while running make (i.e. make W=1) or adding
> > -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.
> 
> By default, we don't care about 'W=1' warnings, as no one sees them, and
> they don't matter.

-Wmissing-prototypes really ought to be defined.

Some of the other warning are a little more pedantic, the most annoying
is -Wsign-compare.  OTOH a lot of code out there is clean enough to build
without any warnings and with a moderate amount of pedantry from the compiler.

OTOH just including extra headers isn't ideal - it can considerably
slow down the compilation time. There are many subsystems that don't
really separate their internal headers from their external ones.

	David