linux-kernel - Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52B40E44.9040603@imgtec.com>
Date:	Fri, 20 Dec 2013 09:30:44 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Chen Gang <gang.chen.5i5j@...il.com>
CC:	<rostedt@...dmis.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<linux-metag@...r.kernel.org>
Subject: Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3()

On 20/12/13 01:44, Chen Gang wrote:
> On 12/19/2013 09:47 PM, James Hogan wrote:
>> No, I believe there shouldn't be any use of the C 64bit division/modulo
>> operations in generic kernel code in the first place, so like I said
>> before the code in question should be fixed to use the proper functions
>> in <linux/math64.h>.
>>
> 
> OK, thanks, your idea is one of fix ways.
> 
> Hmm... for me, it is still not a bad idea to add "__umoddi3" to metag.

NAK

Please read this:
http://yarchive.net/comp/linux/64bit_divide.html

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/