linux-kernel - Re: [PATCH] audit: fix build error when disable audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131220014007.GD14944@madcap2.tricolour.ca>
Date:	Thu, 19 Dec 2013 20:40:07 -0500
From:	Richard Guy Briggs <rgb@...hat.com>
To:	Gao feng <gaofeng@...fujitsu.com>
Cc:	linux-audit@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: fix build error when disable audit

On 13/12/20, Gao feng wrote:
> On 12/20/2013 09:19 AM, Richard Guy Briggs wrote:
> > On 13/12/19, Gao feng wrote:
> >> On 12/19/2013 10:34 AM, Gao feng wrote:
> >>> kernel/capability.c: In function ‘SYSC_capset’:
> >>> kernel/capability.c:280:2: warning: passing argument 1 of ‘audit_log_capset’ makes integer from pointer without a cast [enabled by default]
> >>>   audit_log_capset(new, current_cred());
> >>>   ^
> >>> In file included from kernel/capability.c:10:0:
> >>> include/linux/audit.h:400:20: note: expected ‘pid_t’ but argument is of type ‘struct cred *’
> >>>  static inline void audit_log_capset(pid_t pid, const struct cred *new,
> >>>                     ^
> >>> kernel/capability.c:280:2: error: too few arguments to function ‘audit_log_capset’
> >>>   audit_log_capset(new, current_cred());
> >>>   ^
> >>> In file included from kernel/capability.c:10:0:
> >>> include/linux/audit.h:400:20: note: declared here
> >>>  static inline void audit_log_capset(pid_t pid, const struct cred *new,
> >>>                     ^
> >>> make[1]: *** [kernel/capability.o] Error 1
> >>
> >> BTW, bug introduced by commmit 26b81eb408c411d86c7cc93278fb88fbcd785f65
> >> audit: Simplify and correct audit_log_capset
> > 
> > Yup, found it.  Thanks for the patch.  Since it isn't upstream yet, I
> > may merge it and rebase for linux-next.
> 
> thank you Richard, btw, do you have plan to push these changes to the linux-next?

Yes, that's where I'm putting all these, via Eric.

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/