[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20131220134343.GC3709@lee--X1>
Date: Fri, 20 Dec 2013 13:47:01 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Stephen Warren <swarren@...dotorg.org>
Cc: Laxman Dewangan <ldewangan@...dia.com>, anton@...msg.org,
dwmw2@...radead.org, mark.rutland@....com, rob@...dley.net,
ijc+devicetree@...lion.org.uk, swarren@...dia.com,
devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: AS3722: add dt node properties for system power
controller
> >> ams AS3722 device supports the power off by turning off its all rails.
> >>
> >> Add dt node properties to enable this functionality on this device.
>
> >> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
>
> >> +functionality from ams AS3722:
> >> +ams,system-power-controller: To enable the power off functionality through
> >> + device.
> >
> > Do what with it? "on", "<1>", something else?
>
> It's a Boolean property, so just add the name to the DT, no value.
> Admittedly the binding should state this.
I was being pedantic. ;)
> The series,
>
> Tested-by: Stephen Warren <swarren@...dia.com>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists