linux-kernel - Re: [RFC PATCH 8/8] sched: remove scheduler domain naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131220140842.GW16438@laptop.programming.kicks-ass.net>
Date:	Fri, 20 Dec 2013 15:08:42 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	dietmar.eggemann@....com
Cc:	mingo@...hat.com, vincent.guittot@...aro.org,
	morten.rasmussen@....com, chris.redpath@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 8/8] sched: remove scheduler domain naming

On Fri, Dec 13, 2013 at 12:11:28PM +0000, dietmar.eggemann@....com wrote:
> From: Dietmar Eggemann <dietmar.eggemann@....com>
> 
> In case the arch is allowed to define the conventional scheduler domain
> topology level (i.e. the one without SD_NUMA topology flag) layout, it is
> not feasible any more for the scheduler to name these levels.  Therefore,
> this patch gets rid of of the sched_domain_topology_level structure
> member 'name' and the corresponding SD_INIT_NAME macro.  It was only used
> when CONFIG_SCHED_DEBUG was set any way.

Right, so for debug purposes it might be convenient to keep it; we could
simply put it in the topology array, something like:

 { cpu_smt_mask, SD_SHARE_CPU_POWER | SD_SHARE_PKG_RESOURCE, SD_NAME(smt) },

which would still allow us to make it go away on !debug, but does
provide us with a nice label to print for the debug topology prints.

Alternatively we could do something like:

#define SD_mask(name, flags) \
	{ cpu_##name##_mask, (flags), .name = #name }

to further reduce typing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/