linux-kernel - Re: [PATCH wq/for-3.14 2/2] workqueue: implement @drain for workqueue_set_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131220142321.GC4298@htj.dyndns.org>
Date:	Fri, 20 Dec 2013 09:23:21 -0500
From:	Tejun Heo <tj@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Nigel Cunningham <nigel@...elcunningham.com.au>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Jens Axboe <axboe@...nel.dk>, tomaz.solc@...lix.org,
	aaron.lu@...el.com, linux-kernel@...r.kernel.org,
	Oleg Nesterov <oleg@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH wq/for-3.14 2/2] workqueue: implement @drain for
 workqueue_set_max_active()

On Fri, Dec 20, 2013 at 02:56:09PM +0100, Rafael J. Wysocki wrote:
> On Friday, December 20, 2013 08:32:20 AM Tejun Heo wrote:
> > Hello, Rafael.
> > 
> > On Fri, Dec 20, 2013 at 02:31:37AM +0100, Rafael J. Wysocki wrote:
> > > > If this looks good to you, I'll commit it to wq/for-3.14 and we can at
> > > > least start to clean up things.
> > > 
> > > Yes, it does.
> > > 
> > > So with that I need to do workqueue_set_max_active(wq, WQ_FROZEN_ACTIVE) during
> > > suspend and then workqueue_set_max_active(wq, WQ_DFL_ACTIVE) during resume on
> > > my workqueue, right?
> > 
> > Yeah, you can also do workqueue_set_max_active(wq, 0) during resume to
> > restore the default value, which is what's used by alloc_workqueue()
> > anyway.

Oops, it sould be obvious but just in case.  The call to use during
suspend is workqueue_set_max_active(wq, WQ_FROZEN_ACTIVE, true). :)

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/